Throw compile time error for missing runtime #2450
Conversation
naveen28204280
requested review from
Ralith,
djc and
gretchenfrage
as code owners
Ralith
left a comment
Ralith
left a comment
There was a problem hiding this comment.
Thanks! Please also update the test scripts to pass with this change, as we discussed in the previous PR.
Note also that if you force-push to your branch, it updates your existing PR; you don't need to create a new one, and doing so is usually discouraged as it makes it hard to follow discussion.
quinn/src/runtime/mod.rs
Outdated
| use crate::Instant; | ||
|
|
||
| #[cfg(not(any(feature = "runtime-tokio", feature = "runtime-smol", feature = "custom-runtime")))] | ||
| compile_error!("no async runtime found. Please enable a runtimse such as runtime-tokio, runtime-smol or custom-runtime"); |
There was a problem hiding this comment.
typo: "runtimse". Let's also word this as "a runtime feature" to provide a clearer breadcrumb to users who might not know what we're talking about.
Also please be consistent about capitalization and punctuation: if the text contains multiple sentences, then the first letter should be capitalized and there should be a trailing period.
|
Hi @naveen28204280 -- sorry, I didn't like the direction of this PR much so implemented an alternative in #2451. That means we no longer need this PR -- we still appreciate your efforts, though! |
3 participants
This PR allows to
runtime-tokio,runtime-smol,custom-runtimeare enabled